Fix bugs in TimeIntervalCollection. #6418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shunter, thanks for the pull request! Maintainers, we have a signed CLA from @shunter, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
Replaces #6398. As mentioned above, I kept the new unit tests from that PR. |
shunter
force-pushed
the
fixTimeIntervalCollection
branch
from
6c3b5b7 to
99aaf21
Compare
* Undid extraction of local variable for intervals[index] in `removeInterval` which was not done correctly. * Several places compared JulianDates incorrectly using TimeInterval.equals. I also made the structure of the code match our original C# source as closely as possible, given the language differences. Both of the above errors were a result of the code diverging, in an attempt to clean it up. I also added another unit test ported from our original source, and kept the new unit tests added in #6398 (after fixing them to be correct).
shunter
force-pushed
the
fixTimeIntervalCollection
branch
from
99aaf21 to
6473f2e
Compare
|
Looks great, thanks @shunter! |
|
Nice one :) mmm all those extra unit tests :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeIntervalwhich was not done correctly.I also made the structure of the code match our original C# source as closely as
possible, given the language differences. Both of the above errors were a
result of the code diverging, in an attempt to clean it up.
I also added another unit test ported from our original source, and kept
the new unit tests added in #6398 (after fixing them to be correct).