-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make root tile public #6944
Make root tile public #6944
Conversation
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Looks good, Cesium Viewer still works in all browsers and in 2D/CV. Since this does expose a public way to access |
Ah yes, added an entry to |
* | ||
* @type {TileBoundingVolume} | ||
* @readonly | ||
* @private |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bother adding this if it's marked @private
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much just following what contentBoundingVolume
does. It looks nicer when other files that need this call tile.boundingVolume
instead of tile._boundingVolume
. It can't be public though since TileBoundingVolume
is private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay. We want to access it from other classes without adding it to the public API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
Thanks @lilleyse! |
Thanks for reviewing @OmarShehata! |
Makes
tileset.root
public as a convenience.Cesium3DTile
is already part of the public API so this is safe. A lot of code outside of Cesium is callingtileset._root
and it would be better to calltileset.root
instead. I don't see the harm in making it public.Also added
tile.boundingVolume
since we already havetile.contentBoundingVolume
. They are both@private
still.@OmarShehata can you review?