Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to register custom feature parsers #4

Open
MeFisto94 opened this issue Sep 25, 2024 · 0 comments
Open

Allow plugins to register custom feature parsers #4

MeFisto94 opened this issue Sep 25, 2024 · 0 comments

Comments

@MeFisto94
Copy link
Member

This is an interesting lifecycle question, because in order to be a plugin, you have to declare that via a feature parser, so at the time of loading the plugin, the features have to be parsed already.

Investigate what to do. Can we parse features later after plugins have been loaded, again? Or builtin vs extendable?
Another thought was to declare another feature like:

"andraste.builtin.featureprovider": {
   "featureParsers": [
       "myplugin.feature-one": "MyPlugin.FeatureOneParser"
   ]
}

While that would work, it still would have to duplicate information from the plugin feature or at least require to cross-reference that.
In addition it makes the parsing process still repeated, just transparent to the user. We need to parse this and the plugin feature at least, to be able to register and load all the plugins.

But then we're talking about a bit of json, we could probably just delay passing that with proper architecture around plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant