Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Node in CI #230

Closed
lishaduck opened this issue Aug 24, 2024 · 2 comments · Fixed by #232
Closed

Bump Node in CI #230

lishaduck opened this issue Aug 24, 2024 · 2 comments · Fixed by #232
Assignees
@AndreaPontrandolfo

Comments

@lishaduck
Copy link
Contributor

Sheriff needs 20 (internally at least), but CI only runs 18.
I think that's why #229 keeps failing despite working file locally (latest stable/22)
@lishaduck
Copy link
Contributor Author

Oh, forgot to ping you, @AndreaPontrandolfo.

Can you do this on master, then I can rebase and 🤞 it works?

@AndreaPontrandolfo
Copy link
Owner

yup, i just realized it needs

with: 
  node-version-file: package.json

in order to actually respect the package.json.

@AndreaPontrandolfo AndreaPontrandolfo self-assigned this Aug 24, 2024
@AndreaPontrandolfo AndreaPontrandolfo mentioned this issue Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreaPontrandolfo AndreaPontrandolfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): node version taken from package.json is now respected AndreaPontrandolfo/sheriff
2 participants
@AndreaPontrandolfo @lishaduck