Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PressedBackgroundColor on Frame #73

Closed
1grzyb1 opened this issue Sep 15, 2020 · 7 comments
Closed

PressedBackgroundColor on Frame #73

1grzyb1 opened this issue Sep 15, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@1grzyb1
Copy link

1grzyb1 commented Sep 15, 2020

After aplying PressedBackgroundColor on Frame it removes Frames shadow from HasShadow property.
I checked and PressedOpacity doesn't remove this effect.

@AndreiMisiukevich AndreiMisiukevich added the bug Something isn't working label Sep 15, 2020
@AndreiMisiukevich
Copy link
Owner

iOS, right?

I presume it's XF bug (because PressedBackgroundColor just changes BackgroundColor of the view)

@AndreiMisiukevich AndreiMisiukevich added external bug and removed bug Something isn't working labels Sep 15, 2020
@AndreiMisiukevich
Copy link
Owner

You can try to create a frame, then change its background color in runtime and see if the HasShadow has broken or not

@1grzyb1
Copy link
Author

1grzyb1 commented Sep 15, 2020

Oposite on iOS shadow is rendering but on android don't. I tried to change BackgroundColor in runtime but it doesn't solve the issue.

@AndreiMisiukevich
Copy link
Owner

I guess that's XF issue.
Do shadows render without TouchEff?
What will happen if you change BackgroundColor by button click (Without TouchEff)
If the issue still exists, then it's not related to TouchEff

@1grzyb1
Copy link
Author

1grzyb1 commented Sep 15, 2020

When I change Background color of Frame on button click then Shadow on frame still appear.

@AndreiMisiukevich AndreiMisiukevich added bug Something isn't working and removed external bug labels Sep 15, 2020
@AndreiMisiukevich
Copy link
Owner

Well. need to check. I thought Frame on Android doesn't have a shadow at all

@AndreiMisiukevich AndreiMisiukevich added the help wanted Extra attention is needed label Oct 9, 2020
@AndreiMisiukevich AndreiMisiukevich removed the help wanted Extra attention is needed label Oct 28, 2020
@AndreiMisiukevich
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants