Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a bug where we are trying to create internal AWS tags #8

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Fixing a bug where we are trying to create internal AWS tags #8

merged 1 commit into from
Sep 27, 2018

Conversation

AndrewFarley
Copy link
Owner

Fixes #7

@AndrewFarley AndrewFarley merged commit 2bd4333 into master Sep 27, 2018
@AndrewFarley AndrewFarley deleted the bugfix-skip-internal-tags branch September 27, 2018 06:30
@AndrewFarley
Copy link
Owner Author

Note: Fixed on master beyond just this change... renaming any tags with a key prefix of aws:... to internal-aws:... so it doesn't fail. This way we preserve all keys for informational purposes even if we have to rename it slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndrewFarley