Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: desiredCapacity has been configured. Be aware this will reset the size of your AutoScalingGroup on every deployment #286

Closed
moltar opened this issue Jan 10, 2024 · 4 comments
Milestone

Comments

@moltar
Copy link

moltar commented Jan 10, 2024

[Warning at /.../FckNatAsg] desiredCapacity has been configured. Be aware this will reset the size of your AutoScalingGroup on every deployment. See aws/aws-cdk#5215 [ack: @aws-cdk/aws-autoscaling:desiredCapacitySet]

If this is intended, perhaps we can ack this warning in the construct?

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.Annotations.html#acknowledgewbrwarningid-message

@AndrewGuenther
Copy link
Owner

AndrewGuenther commented Jan 19, 2024

This is intended an I'll add a warning acknowledgement to the construct. Migrating this issue to the construct repo.

@AndrewGuenther AndrewGuenther transferred this issue from AndrewGuenther/fck-nat Jan 19, 2024
@AndrewGuenther AndrewGuenther added this to the 1.3 milestone Jan 19, 2024
@AndrewGuenther
Copy link
Owner

@moltar I thought this would be a quick win, but turns out CDK doesn't really make this possible. As a construct publisher, I cannot blanked acknowledge warnings generated by my construct. That acknowledge warning API only works with an instance of a construct, not the class.

Unless there's some other annotation that can be applied to the class (there doesn't appear to be one) this is sadly not doable.

@AndrewGuenther
Copy link
Owner

After some coffee I just realized it is 100% in my power to do this. Re-opening.

@moltar
Copy link
Author

moltar commented Jan 23, 2024

Thank you 🙏😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants