Skip to content

Commit 8289fdc

Browse files
committed
Adjusted with review comments
1 parent f1ecd51 commit 8289fdc

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

Diff for: .github/CONTRIBUTING.md

+16-17
Original file line numberDiff line numberDiff line change
@@ -38,38 +38,38 @@ Discussion of issues should be placed transparently in the issue tracker here on
3838
AngleSharp and its libraries uses features from the latest versions of C# (e.g., C# 7). You will therefore need a C# compiler that is up for the job.
3939

4040
1. Fork and clone the repo.
41-
2. First try to build the AngleSharp.Core libray and see if you get the tests running.
41+
2. First try to build the AngleSharp.Core library and see if you get the tests running.
4242
3. You will be required to resolve some dependencies via NuGet.
4343

4444
AngleSharp itself does not have dependencies, however, the tests are dependent on NUnit.
4545

46-
The build system of AngleSharp uses Cake. A bootstrap script (build.ps1 for Windows or build.sh for *nix systems) is included. Note, that at the moment AngleSharp may require NuGet 3.5, which looks for MSBuild pre-15, i.e., before Visual Studio 2017 on Windows systems. We aim to drop this requirement enitirely soon.
46+
The build system of AngleSharp uses Cake. A bootstrap script (build.ps1 for Windows or build.sh for *nix systems) is included. Note, that at the moment AngleSharp may require NuGet 3.5, which looks for MSBuild pre-15, i.e., before Visual Studio 2017 on Windows systems. We aim to drop this requirement entirely soon.
4747

4848
### Code Conventions
4949

5050
Most parts in the AngleSharp project are fairly straight forward. Among these are:
5151

52-
- Always use statement blocks for control statements, e.g., in a for-loop, if-condition, ...
53-
- You may use a simple (throw) statement in case of enforcing contracts on argument
54-
- Be explicit about modifiers (some files follow an older convention of the code base, but we settled on the explicit style)
52+
* Always use statement blocks for control statements, e.g., in a for-loop, if-condition, ...
53+
* You may use a simple (throw) statement in case of enforcing contracts on argument
54+
* Be explicit about modifiers (some files follow an older convention of the code base, but we settled on the explicit style)
5555

5656
There are a couple of rules, which are definitely not standard, but highly recommended for consistency and readability:
5757

58-
- AngleSharp uses the RHS convention, where types are always put on the right hand side if possible, i.e., preferring `var` under all circumstances
59-
- A single empty line between two non-simple statements (e.g., for-loop and if-condition) should be inserted
60-
- Types are preferred to keywords (`String` instead of `string` or `Int32` instead of `int`)
61-
- `using` statements must be inside the namespace declaration
58+
* AngleSharp uses the RHS convention, where types are always put on the right hand side if possible, i.e., preferring `var` under all circumstances
59+
* A single empty line between two non-simple statements (e.g., for-loop and if-condition) should be inserted
60+
* Types are preferred to keywords (`String` instead of `string` or `Int32` instead of `int`)
61+
* `using` statements must be inside the namespace declaration
6262

6363
### Development Workflow
6464

6565
1. If no issue already exists for the work you'll be doing, create one to document the problem(s) being solved and self-assign.
6666
2. Otherwise please let us know that you are working on the problem. Regular status updates (e.g. "still in progress", "no time anymore", "practically done", "pull request issued") are highly welcome.
67-
2. Create a new branch—please don't work in the `master` branch directly. It is reserved for releases. We recommend naming the branch to match the issue being addressed (`feature/#777` or `issue-777`).
68-
3. Add failing tests for the change you want to make. Tests are crucial and should be taken from W3C (or other specification).
69-
4. Fix stuff. Always go from edge case to edge case.
70-
5. All tests should pass now. Also your new implementation should not break existing tests.
71-
6. Update the documentation to reflect any changes. (or document such changes in the original issue)
72-
7. Push to your fork or push your issue-specific branch to the main repository, then submit a pull request against `devel`.
67+
3. Create a new branch—please don't work in the `master` branch directly. It is reserved for releases. We recommend naming the branch to match the issue being addressed (`feature/#777` or `issue-777`).
68+
4. Add failing tests for the change you want to make. Tests are crucial and should be taken from W3C (or other specification).
69+
5. Fix stuff. Always go from edge case to edge case.
70+
6. All tests should pass now. Also your new implementation should not break existing tests.
71+
7. Update the documentation to reflect any changes. (or document such changes in the original issue)
72+
8. Push to your fork or push your issue-specific branch to the main repository, then submit a pull request against `devel`.
7373

7474
Just to illustrate the git workflow for AngleSharp a little bit more we've added the following graphs.
7575

@@ -117,7 +117,6 @@ The following files should not be edited directly in the current repository, but
117117
.gitignore
118118
.gitattributes
119119
.github/*
120-
appveyor.yml
121120
build.ps1
122121
build.sh
123122
tools/anglesharp.cake
@@ -127,7 +126,7 @@ LICENSE
127126

128127
To sync manually:
129128

130-
```
129+
```sh
131130
git remote add gitbase git@github.com:AngleSharp/AngleSharp.GitBase.git
132131
git pull gitbase master
133132
```

Diff for: build.sh

100644100755
File mode changed.

0 commit comments

Comments
 (0)