Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating index.ipynb, cell content is not sanitized #1493

Open
ozpau opened this issue Feb 6, 2025 · 2 comments · May be fixed by #1494
Open

When generating index.ipynb, cell content is not sanitized #1493

ozpau opened this issue Feb 6, 2025 · 2 comments · May be fixed by #1494
Labels
bug Something isn't working

Comments

@ozpau
Copy link

ozpau commented Feb 6, 2025

Steps to reproduce

  1. Create a repository with " in description, like this one: https://github.com/ozpau/nbdev_new_cant_handle_this
  2. Clone, cd into it, and call nbdev_new
  3. This will generate invalid index.ipynb: https://github.com/ozpau/nbdev_new_cant_handle_this/blob/main/nbs/index.ipynb?short_path=7a1e639#L19

Notice that double quotation marks that breaks the json.

@ozpau ozpau added the bug Something isn't working label Feb 6, 2025
@ozpau
Copy link
Author

ozpau commented Feb 6, 2025

settings.ini seems fine.

This repo https://github.com/ozpau/nbdev_new_test with sfdasd\n\n\n\n\n\nkeywords = one two three " }] in description doesn't break it.

@ozpau
Copy link
Author

ozpau commented Feb 6, 2025

Generation of nbs/nbdev.yml is also not sanitized: https://github.com/ozpau/nbdev_new_cant_handle_this/blob/main/nbs/nbdev.yml#L7

@ozpau ozpau linked a pull request Feb 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant