Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML tools assume all files have content #3

Closed
polyrand opened this issue Aug 1, 2024 · 0 comments
Closed

XML tools assume all files have content #3

polyrand opened this issue Aug 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@polyrand
Copy link

polyrand commented Aug 1, 2024

This line of code here assumes that the file has contents (when calling s[ 0]), and breaks when that's not the case. This can be problematic when running this tool on Python projects that normally have empty __init__.py files.

Thanks for the great tool!

P.S: I know it's an easy fix and I should probably open a PR, but I would need to get familiar with nbdev first, so I'll open the issue in case it gets fixed before.

@jph00 jph00 closed this as completed in 65f6fa8 Aug 21, 2024
@jph00 jph00 added the bug Something isn't working label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants