Functional tests

[ScottBailey]

Fixes #45

Testing is 90-ish-percent complete.

[jolly-fellow]

As I remember first try to test DUNE and the discussing about this in telegram there were many problems related to shared files between of the host and the container. After that I made this issue #56 and propose to extend this description with all which helps further users to avoid difficulties related to the shares.

[mikelik]

Is it possible to execute those tests in the Github Actions/whenever new merge or PR is created?

[ScottBailey]

@mikelik I do not believe it's possible at this time. At least not for me. That said, maybe @kj4ezj has an opinion?

[jolly-fellow]

Is it possible to execute those tests in the Github Actions/whenever new merge or PR is created?

Theoretically it is possible but a prebuilt Docker image of EOS should be deployed on GitHub Container Registry. Github Actions will create a container from this image and run the tests inside. Bucky said it is a good idea to have a prebuilt image. It will be possible to create containers for CI, testing purposes and for work of end users instead of force each end user build his own image locally.

[mikelik]

Theoretically it is possible but a prebuilt Docker image of EOS should be deployed on GitHub Container Registry.

I think prebuilt Docker image will be fine for release / regression testing.
Can we built a temporary (local) image and run functional tests against it on each PR / merge?
This way we could know if each commit builds valid image.

[jolly-fellow]

Theoretically it is possible but a prebuilt Docker image of EOS should be deployed on GitHub Container Registry.

I think prebuilt Docker image will be fine for release / regression testing. Can we built a temporary (local) image and run functional tests against it on each PR / merge? This way we could know if each commit builds valid image.

Yes of course. Why not? Everyone may build any number of images locally or in his own profile on GitHub or Docker Hub. It is possible to build images for each merge but I'm not sure it is possible for free. And I don't understand why we need to rebuild EOS image for testing DUNE which works outside of container. Anyway it is always possible to build an image locally and push it to the repository for free.
But you are right. Generally the idea is to do tests against official releases and for creation of containers for the end users.

[jolly-fellow]

@ScottBailey It seems solution of the problem with deployment of eosio.system will take more time than I thought so I added issues #80 and #81 to separate it and making of a test for --get-table from this PR, so IMHO you may merge it as is when it will be approved. Bucky is agree.

[ScottBailey]

The following issues have been written to resolve remaining problems: #85 #86

[jolly-fellow]

I don't understand why these directories should be here because normally they should be created before the tests and removed after the tests. If they exist after end of the tests it is a bug.