-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
985376a
to
818e4e5
Compare
runs-on: ubuntu-latest | ||
steps: | ||
- name: Use Docker in rootless mode (To solve "Permission denied" error when removing test_app directory) | ||
uses: ScribeMD/rootless-docker@0.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More explanation can be found here: https://github.com/marketplace/actions/rootless-docker
In short: all docker commands (i.e. creating contracts using DUNE) are executed as root, which causes access issues. Particulary test_app
directory is owned by root, not by user runner
which executes the tests.
run: | | ||
python -m pip install --upgrade pip | ||
pip install pytest | ||
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is obsolete, but doesn't do any harm. In the future we might simply add requirements.txt
file with all python dependencies and the tests would pass without any changes in run-tests.yml
.
uses: docker/setup-buildx-action@v2 | ||
- shell: bash | ||
run: | | ||
./bootstrap.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we built DUNE docker image from scratch (which tests bootstrap.sh and Dockerfile).
I prefer building from scratch than just downloading latest DUNE image from packages (because Dockerfile and bootstrap.sh might change in the meanwhile).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
818e4e5
to
304188f
Compare
Build DUNE docker image and run functional test against it.
Marked 2 tests as ignored as the tests are failing. Separate issues were created for them: