Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: future deprecation of macros CONTRACT,ACTION,TABLE #133

Open
DenisCarriere opened this issue Apr 7, 2023 · 3 comments
Open

Proposal: future deprecation of macros CONTRACT,ACTION,TABLE #133

DenisCarriere opened this issue Apr 7, 2023 · 3 comments

Comments

@DenisCarriere
Copy link
Member

Based on the experience with:

Additionally, macros are no able to handle:

  • [[eosio::on_notify("*::transfer")]]
  • Action return data (example)

As a developer looking at various code examples and seeing these macros, seems like it would cause more confusion and unclear direction on how to implement a proper smart contract.

Since there are still developers using Macros currently, would be best to announce a deprecation notice and later on at a later major release a removal.

  1. Deprecation warning (current)
  2. Removal at next major CDT release (future)
@nsjames
Copy link
Contributor

nsjames commented Apr 7, 2023

Pros: I like the ease of them vs having to write/remember the expanded versions.
Especially for new developers learning the stack.

Cons: Pretty clearly problematic from the issues listed above

I sent this ticket to the antelope dev chat so we can open up some discussion about them and see what directions should be taken.

@poplexity
Copy link

In addition to the more explicit issues described above, I'd be in favor of one way to do things just for consistency's sake. A developer might be familiar with one style and that means the other style can be confusing to read.

I'd also like to put name("bob") vs "bob"_n on the chopping block for the same reason, and personally prefer name("bob") for readability to anyone new to CDT.

@stephenpdeos
Copy link
Member

Deprecation will be announced in upcoming CDT v4.0.0 release

@stephenpdeos stephenpdeos self-assigned this Apr 19, 2023
@stephenpdeos stephenpdeos added this to the CDT 4.0.0-rc1 milestone Apr 19, 2023
@stephenpdeos stephenpdeos removed this from the CDT 4.0.0-rc2 milestone May 9, 2023
@ericpassmore ericpassmore added this to the CDT 5.0.0-rc1 milestone Aug 11, 2023
@ericpassmore ericpassmore modified the milestones: CDT 4.1.0-rc1, Future Milestone Aug 24, 2023
@arhag arhag removed this from the Future Milestone milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

7 participants