-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish integrating BLS into CDT main branch #202
Comments
integration tests do not work because of leap#1462 |
EOS EVM PR in progress to support/unblock. AntelopeIO/bls12-381#5 |
Key dependency the EOS EVM PR is closed closing this issue as well. |
I am reopening this issue.
@ericpassmore: Note that we closed AntelopeIO/bls12-381#5 because we decided to go with the alternative of AntelopeIO/bls12-381#6 instead. That PR is also closed (in that case merged in rather than rejected). However, the fixes are not yet incorporated into Leap until AntelopeIO/leap#1486 has been merged in. That would then allow us to complete AntelopeIO/leap#1413. Once AntelopeIO/leap#1413 is completed, that unblocks the following work called out in the description of this issue:
Note that the task list in this issue does not yet have individual issues for that work. I know that @dimas1185 has a PR up (#203) for part of that work already. |
#154 was merged into the
bls_integration
branch as part of completing the BLS milestone of IF. However, some changes still remain before the code can be merged into main.First, the branch should be updated to use the leap-dev package generated from the
bls_integration
branch in Leap so that the integration tests can correctly run. Use this to ensure all the tests are running as intended.Then, when AntelopeIO/leap#1413 is completed, which means BLS support is integrated into the
main
branch of Leap, thebls_integration
branch should again be updated to use the leap-dev package from themain
branch of Leap. The code changes of that branch (with CICD all passing) should then be merged into themain
branch of CDT.Tasks
The text was updated successfully, but these errors were encountered: