Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish integrating BLS into CDT main branch #202

Closed
1 task done
Tracked by #39
arhag opened this issue Jul 18, 2023 · 4 comments · Fixed by #211
Closed
1 task done
Tracked by #39

Finish integrating BLS into CDT main branch #202

arhag opened this issue Jul 18, 2023 · 4 comments · Fixed by #211
Assignees
Milestone

Comments

@arhag
Copy link
Member

arhag commented Jul 18, 2023

#154 was merged into the bls_integration branch as part of completing the BLS milestone of IF. However, some changes still remain before the code can be merged into main.

First, the branch should be updated to use the leap-dev package generated from the bls_integration branch in Leap so that the integration tests can correctly run. Use this to ensure all the tests are running as intended.

Then, when AntelopeIO/leap#1413 is completed, which means BLS support is integrated into the main branch of Leap, the bls_integration branch should again be updated to use the leap-dev package from the main branch of Leap. The code changes of that branch (with CICD all passing) should then be merged into the main branch of CDT.

Tasks

  1. bug 👍 lgtm
    yarkinwho
@dimas1185
Copy link
Contributor

integration tests do not work because of leap#1462
make sense to finish after those will be fixed

@BenjaminGormanPMP
Copy link

EOS EVM PR in progress to support/unblock. AntelopeIO/bls12-381#5

@ericpassmore ericpassmore added this to the CDT 4.0.1 milestone Aug 11, 2023
@ericpassmore
Copy link
Contributor

Key dependency the EOS EVM PR is closed closing this issue as well.

@arhag
Copy link
Member Author

arhag commented Aug 15, 2023

I am reopening this issue.

Key dependency the EOS EVM PR is closed closing this issue as well.

@ericpassmore: Note that we closed AntelopeIO/bls12-381#5 because we decided to go with the alternative of AntelopeIO/bls12-381#6 instead. That PR is also closed (in that case merged in rather than rejected). However, the fixes are not yet incorporated into Leap until AntelopeIO/leap#1486 has been merged in. That would then allow us to complete AntelopeIO/leap#1413.

Once AntelopeIO/leap#1413 is completed, that unblocks the following work called out in the description of this issue:

Then, when AntelopeIO/leap#1413 is completed, which means BLS support is integrated into the main branch of Leap, the bls_integration branch should again be updated to use the leap-dev package from the main branch of Leap. The code changes of that branch (with CICD all passing) should then be merged into the main branch of CDT.

Note that the task list in this issue does not yet have individual issues for that work. I know that @dimas1185 has a PR up (#203) for part of that work already.

@arhag arhag reopened this Aug 15, 2023
@arhag arhag modified the milestones: CDT 4.0.1, CDT 5.0.0-rc1 Aug 17, 2023
@dimas1185 dimas1185 mentioned this issue Aug 22, 2023
2 tasks
@arhag arhag modified the milestones: Unknown, CDT Next Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants