Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to configure tray icon on Plasma #201

Closed
RX0FA opened this issue Jul 6, 2024 · 3 comments · Fixed by #202
Closed

Unable to configure tray icon on Plasma #201

RX0FA opened this issue Jul 6, 2024 · 3 comments · Fixed by #202
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@RX0FA
Copy link
Contributor

RX0FA commented Jul 6, 2024

Environment

  • Distribution: Arch Linux
  • Arch-Update version: 2.1.0

Description of the bug

Tray icons on Plasma can be shown always besides other tray icons or can be shown on the tray icons popup (triggered by the arrow button shown in the picture).
image

It seems that due to missing arguments on QApplication (at src/script/arch-update-tray.py), the Arch-Update tray icon can not be configured under Plasma.

Screenshots / Logs

Current parameters: QApplication([])
ARCH-BEFORE

When setting up the first parameter, the icon issue is fixed and the first argument will be used as application title e.g. QApplication(["Arch-Update"])
ARCH-AFTER

@RX0FA RX0FA added the bug Something isn't working label Jul 6, 2024
@Antiz96 Antiz96 added this to the v2.2.0 milestone Jul 6, 2024
@Antiz96
Copy link
Owner

Antiz96 commented Jul 6, 2024

Hi,

Thanks a lot for the detailed report! 🙏

I am planning on releasing v2.2.0 later today, it would be great to include this trivial fix in it! 😄

Would you be willing to open a pull request for it?
If not, I can just commit it myself. It's up to you 😉

In any case, thanks once again!

@Antiz96 Antiz96 added the good first issue Good for newcomers label Jul 6, 2024
@RX0FA
Copy link
Contributor Author

RX0FA commented Jul 6, 2024

PR created :)

@Antiz96
Copy link
Owner

Antiz96 commented Jul 6, 2024

PR created :)

Merged ;)

As I said, I'm planning on releasing v2.2.0 later today, including this fix.

Thanks once again for the bug report and the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants