Make Python/PySys detection more reliable #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check for empty interpeter_path config as well as the default value - Check for version information of the form "Python x.y.z"
Merge from upstream
Sync with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey John, here's my attempt to fix an issue (#22) I hit using the plugin with a remote WSL2 Ubuntu 18.04 environment, where it failed to find a Python installation despite there being at least two of them on the path. There were two different problems:
Python x.y.zin response to-Vso we probably need to look forythonas well asersionin the output.get("interpreter_path","na")was returning an empty string rather thanna. No idea why, but I bodged in a check for that anyway.It seems to work for me now but given that my knowledge of TypeScript is near-zero and of VS Code extensions even less, I have probably missed the real problem and/or implemented the fix in a horrible way. Hopefully this is some use regardless.
Cheers,
Scott