Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host demo app [SBK-325] #59

Closed
fubuloubu opened this issue Oct 13, 2023 · 5 comments · Fixed by #86
Closed

Host demo app [SBK-325] #59

fubuloubu opened this issue Oct 13, 2023 · 5 comments · Fixed by #86
Assignees

Comments

@fubuloubu
Copy link
Member

Add hosting for demo app against Sepolia deployment

Make sure it works in PRs so it's easier to review changes to the component lib

related to #53

@vany365 vany365 changed the title Host demo app Host demo app [SBK-325] Oct 13, 2023
@fubuloubu
Copy link
Member Author

maybe use vercel

@mikeshultz mikeshultz self-assigned this Oct 13, 2023
@mikeshultz
Copy link
Contributor

For RAs to easily review PR changes.

@mikeshultz mikeshultz assigned alexisnsns and unassigned mikeshultz Oct 13, 2023
@alexisnsns
Copy link
Contributor

Now that we have working local installs we can give this another try

@fubuloubu
Copy link
Member Author

Note that vercel still won't work without the ability to run ape compile

@mikeshultz
Copy link
Contributor

I mentioned it in #69, but what if we just included the manifest in the source tree? We just commit updates when the contract changes. It's something that we would have to explicitly do which is a little annoying, but it should be rare. Then we don't need to compile anything during SDK builds.

@alexisnsns alexisnsns linked a pull request Dec 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants