Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local ape version uses whatever tag is latest [APE-114] #90

Closed
fubuloubu opened this issue Jul 13, 2021 · 3 comments · Fixed by #1394
Closed

Local ape version uses whatever tag is latest [APE-114] #90

fubuloubu opened this issue Jul 13, 2021 · 3 comments · Fixed by #1394
Labels
category: docs Improvements or additions to documentation

Comments

@fubuloubu
Copy link
Member

Just keeping this around as a notice

You might run into issues where you have a local install and are trying to work with a plugin pinned to a specific version.

While the code might be correct, the version will be off because of how setuptools-scm uses git tags to generate the latest version.

The easy solution to this is simple fetch the tags via git fetch upstream --tags and reinstall via pip install .. You will then have the correct version

@fubuloubu fubuloubu added category: bug Something isn't working status: wontfix This will not be worked on labels Jul 13, 2021
@antazoey
Copy link
Member

I can't see this notice getting read too much since it is hidden in the backlog of issues.

I think a note like this belongs in the CONTRIBUTING.md guide. Reason: Contributors are typically the people who do local installs and thus this message mostly caters to them. They probably are more like to read a contributing guide (I hope) then to stumble on this issue.

^ If we agree on that, let's convert this issue to a ticket item (remove the wontfix) and get this note in a spot where people will see it

@fubuloubu
Copy link
Member Author

What if we just pinned the issue?

@NotPeopling2day
Copy link
Contributor

NotPeopling2day commented Apr 4, 2023

I agree, seems to be an issue that would be more specific to Contributors and putting in the guide would cut down on the frustration of trying to look for the issue. I'm removing wontfix and making this a ticket to add the language to the CONTRIBUTING.md guide.

https://linear.app/apeworx/issue/APE-114/docs-update-contributing-guide-to-include-note-about-local-installs

@NotPeopling2day NotPeopling2day added category: docs Improvements or additions to documentation and removed category: bug Something isn't working status: wontfix This will not be worked on labels Apr 4, 2023
@NotPeopling2day NotPeopling2day changed the title Local ape version uses whatever tag is latest Local ape version uses whatever tag is latest [APE-114] Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants