Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Address type #15

Open
NotPeopling2day opened this issue Sep 2, 2022 · 2 comments
Open

Add Address type #15

NotPeopling2day opened this issue Sep 2, 2022 · 2 comments
Labels
category: feature New feature or request size: 2 pieces Relatively easy, but requires some thought

Comments

@NotPeopling2day
Copy link
Contributor

NotPeopling2day commented Sep 2, 2022 •
edited
Loading

Overview

While working on gas reporting, @fubuloubu mentioned wishing address type was more optimized. The original thought is to use an Address(HexBytes) class.

Specification

A little research is needed to see how well this fits with trace/gas reporting.

Dependencies

APE-58
@NotPeopling2day NotPeopling2day added category: feature New feature or request size: 2 pieces Relatively easy, but requires some thought labels Sep 2, 2022
@NotPeopling2day NotPeopling2day mentioned this issue Sep 2, 2022
Merged
4 tasks
@fubuloubu
Copy link
Member

would be even nicer if it was just the same type that ape core uses, so conversion wasn't necessary

@NotPeopling2day
Copy link
Contributor Author

@antazoey Should we use https://github.com/ApeWorX/eth-pydantic-types?tab=readme-ov-file#address for the address type issue? Or do you think we're okay how we're currently using address with eth_pydantic_types HexBytes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: feature New feature or request size: 2 pieces Relatively easy, but requires some thought
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fubuloubu @NotPeopling2day