Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_random_rpc so that it will choose an RPC that won't fail to connect #13

Closed
dtdang opened this issue Jun 13, 2024 · 5 comments · Fixed by #16
Closed

Fix get_random_rpc so that it will choose an RPC that won't fail to connect #13

dtdang opened this issue Jun 13, 2024 · 5 comments · Fixed by #16
Assignees
Labels
category: bug Something isn't working

Comments

@dtdang
Copy link

dtdang commented Jun 13, 2024

Update get_random_rpc so that it doesn't choose an rpc that requires a token that the user doesn't have causing an error like ape.exceptions.ProviderError: No (supported) node found on 'https://sepolia.infura.io/[hidden]'.

Copy link

linear bot commented Jun 13, 2024

@mikeshultz
Copy link
Contributor

mikeshultz commented Jun 13, 2024

Here's the offending line:

"https://sepolia.infura.io/v3/${INFURA_API_KEY}",

Agreed, this is a bug.

Unfortunately, there's a few networks where the Infura node is one of 2 available public nodes. We could have that function look for a matching env var during selection and return it if possible. Or just filter them out from the list entirely. I don't have strong feelings either way. Thoughts?

@mikeshultz mikeshultz added the category: bug Something isn't working label Jun 13, 2024
@dtdang
Copy link
Author

dtdang commented Jun 14, 2024

It's not just the infura rpc that shows this error. I've also noticed it when it is trying to connect with tenderly node as well
"https://sepolia.gateway.tenderly.co",

Not sure if there are more rpcs that are affected by this currently.

@mikeshultz
Copy link
Contributor

It's not just the infura rpc that shows this error. I've also noticed it when it is trying to connect with tenderly node as well "https://sepolia.gateway.tenderly.co",

The linked tenderly RPC doesn't have the same issue with the required keys. If you can repro and confirm that error, can you post it? We can blacklist it if it doesn't work.

@mikeshultz mikeshultz self-assigned this Jun 14, 2024
@dtdang
Copy link
Author

dtdang commented Jun 14, 2024

It's not just the infura rpc that shows this error. I've also noticed it when it is trying to connect with tenderly node as well "https://sepolia.gateway.tenderly.co",

The linked tenderly RPC doesn't have the same issue with the required keys. If you can repro and confirm that error, can you post it? We can blacklist it if it doesn't work.

You were right. Seems to be just an issue from just infura when I'm trying to connect to the network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants