Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent output across solc versions #54

Closed
iamdefinitelyahuman opened this issue Apr 23, 2020 · 1 comment
Closed

Ensure consistent output across solc versions #54

iamdefinitelyahuman opened this issue Apr 23, 2020 · 1 comment
Labels
test Related to unit tests for this project

Comments

@iamdefinitelyahuman
Copy link
Contributor

Overview

I should be able to call compile_sources or compile_files with:

  • any number of sources
  • any combination of expected outputs
  • any active version of solc

and get a consistent output format.

I should be able to look this output format up in the documentation.

Specification

  1. Create parametrized unit tests to verify that output is consistent across versions.
  2. Where there are inconsistencies, solve using common sense.
  3. Document everything

Dependencies

Step one requires #53 .
Step three requres #52 .

@iamdefinitelyahuman iamdefinitelyahuman added the test Related to unit tests for this project label Apr 23, 2020
@iamdefinitelyahuman iamdefinitelyahuman added this to the py-solc-x 1.0.0 milestone Apr 23, 2020
@iamdefinitelyahuman
Copy link
Contributor Author

Since #96 reduces the possible kwargs for the main compiler functions, this is now largely irrelevent. The wrapper might produce different outputs for different solc versions, but I think this can be considered expected when accessing the wrapper directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to unit tests for this project
Projects
None yet
Development

No branches or pull requests

1 participant