Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 bit arm not supported #86

Closed
MatthiasLohr opened this issue Jul 15, 2020 · 10 comments
Closed

64 bit arm not supported #86

MatthiasLohr opened this issue Jul 15, 2020 · 10 comments

Comments

@MatthiasLohr
Copy link
Contributor

Environment information

  • py-solc-x Version: 0.10.0
  • solc Version: 0.6.1
  • Python Version: 3.8.2
  • OS: Ubuntu (Raspberry Pi, 64 Bit)

What was wrong?

According to release v0.10.0, arm architectures should be supported. However, it seems that this support is only limited to 32 bit arm architectures.

Code is checking for platform.machine() ^= "arm", but on my Raspberry Pi 3 B+ with Ubuntu/64 bit support, platform.machine() returns aarch64.

@iamdefinitelyahuman
Copy link
Contributor

Good catch.. the fix should be as easy as adding a check for aarch in install.py i think?

https://github.com/iamdefinitelyahuman/py-solc-x/blob/38f767f88f83046358d096f0ec27b60c612cd329/solcx/install.py#L48-L54

I have no way to test this. Would you be willing to fork and make the edit and see if it works as expected? 🙏

@MatthiasLohr
Copy link
Contributor Author

Will do!

@iamdefinitelyahuman
Copy link
Contributor

Also worth noting, there is an effort right now to increase the availability of solc binaries: ethereum/solidity#9258

This repo is due for a refactor and a new major release, I've been holding off in hopes that osx and arm binaries are made available so these sort of issues become less-so....

@MatthiasLohr
Copy link
Contributor Author

Ok, it's compiling.. since about 30 minutes (and it shows 21%). Compiling on an ARM seems not to be the best idea :D

First thing learned: Maybe binary filenames should be postfixed with architecture. If file solc-v0.6.5 exists, it will just try to execute it, no matter on which architecture we are now and for which architecture is was built.

@MatthiasLohr
Copy link
Contributor Author

Next thing learned: Don't try it with only 1GB RAM.

@MatthiasLohr
Copy link
Contributor Author

:) What about a release now?

@iamdefinitelyahuman
Copy link
Contributor

#89 incoming

@iamdefinitelyahuman
Copy link
Contributor

https://github.com/iamdefinitelyahuman/py-solc-x/releases/tag/v0.10.1

thanks for all your help with this release!

@MatthiasLohr
Copy link
Contributor Author

Sure! And thanks for reacting so quickly! Update is already installed, will test now.

@T3Crypto
Copy link

Downloaded the tar.gz file and ran the "pip install py-solc-x" command on Raspberry Pi 4 terminal. However, the installation is still not successful. May someone please advise as to what steps should be taken? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants