Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to Registry search results (capped by configurable # of labels to return per item) #5378

Closed
EricWittmann opened this issue Oct 21, 2024 · 2 comments
Assignees
Labels
DUPLICATE This issue or pull request already exists
Milestone

Comments

@EricWittmann
Copy link
Member

EricWittmann commented Oct 21, 2024

The idea here is to include labels for Groups, Artifacts, and Versions in search results for those entities. We don't do that now because the # of labels is unbounded, and it's not great practice to return an unbounded collection in a REST API response, let alone an unbounded number of items per search result item.

So we're going to return labels, but we'll cap the # of labels per item. The cap will be globally configurable via an ENV var.

@EricWittmann
Copy link
Member Author

Duplicate of: #5219

@EricWittmann EricWittmann added DUPLICATE This issue or pull request already exists and removed type/enhancement New feature or request component/registry priority/normal area/rest-api labels Oct 23, 2024
@EricWittmann
Copy link
Member Author

Closing as duplicate.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Registry 3.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DUPLICATE This issue or pull request already exists
Projects
Status: Done
Development

No branches or pull requests

1 participant