Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should swap bytes be an extension Method to span? One method per swap type (little, big, vax endian) ... How to handle type size? #125

Open
Apollo3zehn opened this issue Aug 7, 2024 · 2 comments
Labels

Comments

@Apollo3zehn
Copy link
Owner

https://github.com/search?q=repo%3AApollo3zehn%2FFluentModbus%20swapbytes&type=code

@Apollo3zehn Apollo3zehn added the v6 label Aug 7, 2024
@iamalexcater
Copy link

My gut feeling is no; would it not be better to follow the design of the BinaryPrimitives class? (or use it, ultimately)

@Apollo3zehn
Copy link
Owner Author

I will work out some use cases and then try to make all of them usable in a clear way. But thanks for your feedback!

I have often tried to use BinaryPrimitives but for high performance I want to use a vectorized algorithm (which already exists in a different project). I just need to copy it over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants