Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDMap in shared memory #1420

Closed
xiaoxq opened this issue Nov 23, 2017 · 0 comments
Closed

HDMap in shared memory #1420

xiaoxq opened this issue Nov 23, 2017 · 0 comments
Assignees
@startcode @xiaoxq
Labels
Module: HD Map Indicates HD Map module related issues Type: Enhancement Indicates code improvements, feature improvements

Comments

@xiaoxq
Copy link
Contributor

xiaoxq commented Nov 23, 2017 •
edited
Loading

Multiple processes need to keep an HDMap instance with identical read-only data, which is a huge waste of memory. So we think that having single map in shared memory would be a good thing. It could save GBs of memory for a map larger than 200MB.

However, the memory allocation mechanism for protobuf is tricky, especially for string fields:
https://developers.google.com/protocol-buffers/docs/reference/arenas#arenastring

For now, we will mark this situation as HARD and leave as it is. May revisit in the future if it becomes a real pain or easier to resolve.
@xiaoxq xiaoxq added the Type: Enhancement Indicates code improvements, feature improvements label Nov 23, 2017
@xiaoxq xiaoxq closed this as completed Nov 23, 2017
@eugenegx eugenegx added the Module: HD Map Indicates HD Map module related issues label Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@startcode startcode

@xiaoxq xiaoxq

Labels
Module: HD Map Indicates HD Map module related issues Type: Enhancement Indicates code improvements, feature improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@startcode @xiaoxq @eugenegx