[Feature request]: StrategyHelper, DisposeHelper, TimeProviderExtensions, TaskHelper should be public not internal

[mhsimkin]

Is your feature request related to a specific problem? Or an existing feature?

If you need to add a new strategy and want to use StrategyHelper.ExecuteCallbackSafeAsync, DisposeHelper.TryDisposeSafeAsync, TimeProviderExtensions::DelayAsync, TaskHelper::GetResult you can't as they are marked internal.

Describe the solution you'd like

StrategyHelper, DisposeHelper, TimeProviderExtensions should be made public.

Additional context

Referencing this discussion with @peter-csala. After taking the provided code and building a simple test application I determined that the functionality provided by chaining strategies didn't work the way I needed.

I decided to build my own strategy, using the RetryResilienceStrategy as a starting point. Unfortunately, the three (3) classes indicated above are marked as internal, therefore I had to create my own implementation.

I should be able to use these classes in my strategy to minimize my introduction in bugs and to allow the Polly team to resolve any issues that might requite these methods in the indicated classes to be updated.

[martincostello]

We can consider making it easier for people to extend things, but it's unlikely we'd expose these types as-is.

[peter-csala]

I determined that the functionality provided by chaining strategies didn't work the way I needed.

Could you please elaborate what is missing? How do you want to implement your own custom retry strategy?

[mhsimkin]

I will add a reply to the discuss of what the issues were.

[martintmk]

I agree with @martincostello , it's unlikely that we will expose these primitives as we want to keep our API surface as thin as possible. Most of these are quite simple, so copy & paste is your friend.

[peter-csala]

@mhsimkin Hi Marc, as you have indicated in the discussion the proposed solution worked for you. Can you please close this issue because as far as I can tell your feature request is not necessary anymore.

I'm planning to add the code to the samples and document it under the extensibility section next week.

[mhsimkin]

This is no longer needed as @peter-csala and I have come up with a working solution. Please see this discussion for the details.