[FR] Markdown divider implement ___

[annieappflowy]

Description

You can use ___ on its own line to add a horizontal bar.

Impact

Markdown users

Additional Context

No response

[AmanNegi]

Hey there, I would like to work on this. If I'm right this is similar to our Octernship task right?

[annieappflowy]

This is to implement a markdown syntax
@AmanNegi , would you like to give it a try?

[AmanNegi]

I would like to but I didn't get what you exactly meant by implementing a markdown syntax. If something similar is already implemented could you please redirect me?

[annieappflowy]

The Markdown guidebook: https://appflowy.gitbook.io/docs/essential-documentation/markdown
An example illustrating how to implement: #1100

[AmanNegi]

Yeah this is similar to the Octernship task... I can surely work on this

[annieappflowy]

Sounds good! Thank you 🙏

[AmanNegi]

Hey there, sorry I was busy so this issue went inactive. I just now started looking at this issue, however I just noticed that --- has been previously implemented to add divider but it doesn't work currently. Also, I wanted to ask that the appflowy_editor was previously released separately, so is this issue still relevant here?

[Xazin]

Hey there, sorry I was busy so this issue went inactive. I just now started looking at this issue, however I just noticed that --- has been previously implemented to add divider but it doesn't work currently. Also, I wanted to ask that the appflowy_editor was previously released separately, so is this issue still relevant here?

It should be implemented in the appflowy_editor repository.

Most, if not all, issues that have the tag Editor are related to the appflowy_editor project, and thus have to be implemented there.

All that has happened, is that the editor itself was decoupled from AppFlowy project, allowing others to easily adopt the Editor to build their own applications.

[AmanNegi]

Okay great thanks a lot for the clarification @Xazin. However, I believe that we are supposed to create the shortcuts, builders and menu item within the main project itself, as we already have a few under plugins\document\presentation\plugins. Correct me if I am wrong here.

Can you please clarify on this @LucasXu0.

[Xazin]

Okay great thanks a lot for the clarification @Xazin. However, I believe that we are supposed to create the shortcuts, builders and menu item within the main project itself, as we already have a few under plugins\document\presentation\plugins. Correct me if I am wrong here.

Can you please clarify on this @LucasXu0.

I don't think so, divider is a common markdown syntax, I'm not sure why it was implemented in the main project, it's most likely a remnant. This https://github.com/AppFlowy-IO/AppFlowy/tree/main/frontend/appflowy_flutter/lib/plugins/document/presentation/plugins/divider should be moved to the editor at this location https://github.com/AppFlowy-IO/appflowy-editor/tree/main/lib/src/render

Along with what it touches. (And support for ___ should be added)

Similary the markdown encoder/decoder should be updated to include the divider notation support. See https://github.com/AppFlowy-IO/appflowy-editor/tree/main/lib/src/plugins/markdown

[AmanNegi]

Okay, so we are supposed to make the changes in the editor repo. Sorry for the delay, now that it's clear I will work on this immediately. ✨

[annieappflowy]

Not related to the thread...
@AmanNegi , what's your Discord handle? Please DM me on Discord.

[annieappflowy]

@AmanNegi , are you still working on this?

[AmanNegi]

Yep now I am working on this, was waiting for the merging of develop and main branch.

[Xazin]

Yep now I am working on this, was waiting for the merging of develop and main branch.

See for reference AppFlowy-IO/appflowy-editor#118
All you need to do is add a Shortcut for _ that triggers the insertDividerHandler.

On editor repo.

[AmanNegi]

Thanks for the reference @Xazin. Perhaps should I move this issue in the editor_repo?

[Xazin]

Thanks for the reference @Xazin. Perhaps should I move this issue in the editor_repo?

No need, it's fine, we can still link to this issue from the PR.

[AmanNegi]

Okay great! 😺