Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate test AppImage files #116

Open
azubieta opened this issue May 17, 2019 · 3 comments
Open

Generate test AppImage files #116

azubieta opened this issue May 17, 2019 · 3 comments

Comments

@azubieta
Copy link
Contributor

As we keep adding tests new AppImage files will be required to test each scenario. Having all of them in the sources repository will just make our repository bigger and slower to clone. As most of such files can be generated using appimagetool we must just include the recipes and generate them while building the whole project.

@TheAssassin
Copy link
Member

I think this library should not rely on actual files for tests, but instead test things unit wise with the minimum relevant amount of data for this purpose.

@azubieta
Copy link
Contributor Author

azubieta commented May 17, 2019

Indeed we can test a wide range of features with the approach you propose. But in the end we will also have to test if on real files. Otherwise it would remain incomplete.

@TheAssassin
Copy link
Member

TheAssassin commented May 17, 2019

Sure. But not to just see whether parsing a broken desktop file will return in a specific error...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants