Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing functionality on posts in Tumblr Communities #1441

Open
5 of 8 tasks
marcustyphoon opened this issue Apr 20, 2024 · 1 comment
Open
5 of 8 tasks

Missing functionality on posts in Tumblr Communities #1441

marcustyphoon opened this issue Apr 20, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@marcustyphoon
Copy link
Collaborator

marcustyphoon commented Apr 20, 2024

Platform

MacOS 14.4.1 arm64

Browser

Chrome 123.0.6312.87

Addon version

v0.23.4

Details

Needs tweaking:

Maybe:

  • Mutual checker works with no changes on Communities pages, but it's firing API requests unnecessarily rather than parsing authorBlog when blog doesn't match. The code change to improve this is somewhat awkward, though. Mutual Checker: Reduce API load on communities pages #1576
  • I can't test Quick Tags on Communities.
  • I can't test Trim Reblogs on Communities.
  • I can't test NotificationBlock on Communities (blockPostFilter may be wrong, and the apiFetch to check if the post is muted probably crashes if the button actually is clickable? most likely fine though)

The Tumblr Communities feature, which is currently in a closed beta, contains posts that work differently than other posts in the Tumblr ecosystem, and also include changes to the way the API data underlying posts are used. This currently causes/probably will cause some XKit Rewritten functionality not to work properly within communities.

Particularly, community posts are displayed (generally speaking) as if they belong to the blog of the user who composed them, but the API data is more similar to a submission from that user to a generic blog.

In the case of Themed Posts, this just results in erroneous behavior: we want to match the theme we render a post with the way it otherwise appears, so we'll need a method to get a post's "blog" that isn't actually just the blog property of its API data. A number of other scripts look like they'll fall into this category (I can't tell right now; I'm not in the beta).

In some other cases, it would make sense for scripts to treat the submitting blog of a submission equally with the owning blog. For example, Quick Reblog automatically suggests a tag for the blog name; it may as well suggest the submitting blog's name too. In these cases there doesn't need to be special behavior for community posts.

@marcustyphoon

This comment was marked as outdated.

@marcustyphoon marcustyphoon unpinned this issue Jun 12, 2024
@marcustyphoon marcustyphoon changed the title Incorrect blog detection in Tumblr Communities Missing functionality on posts in Tumblr Communities Aug 17, 2024
@marcustyphoon marcustyphoon pinned this issue Aug 17, 2024
@marcustyphoon marcustyphoon self-assigned this Aug 19, 2024
@marcustyphoon marcustyphoon removed the help wanted Extra attention is needed label Aug 19, 2024
@marcustyphoon marcustyphoon unpinned this issue Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant