Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip component sometimes breaks app #575

Closed
henry-chris opened this issue Apr 17, 2020 · 3 comments
Closed

Tooltip component sometimes breaks app #575

henry-chris opened this issue Apr 17, 2020 · 3 comments
Assignees

Comments

@henry-chris
Copy link

We see this very randomly and sporadically. I haven't figured out what's causing it yet, and we can't reproduce it readily.

It seems that somehow the following code in ToolTip.js cannot find 'top' of undefined. That's the error we get in this file.

image

I'm guessing that it occurs when the bestLocation cannot be found from the .find() function. I did not get a shot of the specific line of code of the error sadly.

Putting some null checks and logging around each access of locationTopLeftMap on our end to see if I can pinpoint the cause. Just wanted to let you know.

@ZhijieZhang
Copy link
Contributor

Thanks for bringing this up and sorry for the delay in the reply. I'm still kind of busy with other stuff.

If bestLocation cannot be found it means the there's no place in the viewport that can show the entire tooltip component. I can't think any cases where this can happen, but I must miss some edge cases since you were seeing errors about this.

I think I'm going to add a fallback location to fix this issue.

@ZhijieZhang ZhijieZhang self-assigned this Apr 22, 2020
@henry-chris
Copy link
Author

No worries. Ya, it's strange as it doesn't seem like it's possible.

Once you add this one, i'll take a nightly and start incorporating it when possible. I think we've heard back on everything.

@ZhijieZhang
Copy link
Contributor

Just pushed a fix to this issue. The fix should be available at tomorrow's nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants