Skip to content

Latest commit

 

History

History
49 lines (30 loc) · 2.32 KB

File metadata and controls

49 lines (30 loc) · 2.32 KB
description
Use KernelPlatform.GetTerminalType()

📉 Kernel - NKS0043

This analyzer provides the following strings:

ContextString
Error ListCaller uses Environment.GetEnvironmentVariable("TERM") instead of KernelPlatform.GetTerminalType()
Suggestion BoxUse KernelPlatform.GetTerminalType() instead of Environment.GetEnvironmentVariable("TERM")
DescriptionKernelPlatform.GetTerminalType() is more readable and less verbose than Environment.GetEnvironmentVariable("TERM").

Extended Description

This code analyzer detects the usage of GetEnvironmentVariable("TERM") from the Environment class found in the System namespace.

GetEnvironmentVariable is a method to determine the terminal emulator and the terminal type. It's also a method to determine whether it's running on GNU Screen or on Tmux. However, we needed to increase the readability.

As a result, KernelPlatform implements a handful of terminal detection functions to simplify the complicated terminal checking statements to its simpler equivalent.

Analysis Comparison

To get a brief insight about how this analyzer works, compare the two code blocks shown to you below:

Before the fix

public static void MyFunction()
{
    var value = Environment.GetEnvironmentVariable("TERM");
}

After the fix

public static void MyFunction()
{
    var value = KernelPlatform.GetTerminalType();
}

Suppression

You can suppress this suggestion by including it in the appropriate place, whichever is convenient.

For more information about how to suppress any warning issued by the Nitrocid analyzer, visit the below page:

{% embed url="https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/suppress-warnings" %}

Recommendation

We recommend that every caller which use this function use the recommended abovementioned method.