-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt to upcoming notify
api (M2)
#9
Comments
There is a problem I see here.... the notify API requires the notification message to be set in |
i am sceptical in having different messages etc. for different users, this might be somehow confusing as well - but we can always improve, not saying we cannot have sth like that at some point, but currently i do not think, it is needed and we should keep simple. for the issue at hand, it is probably fine to just do the collapsing as usual (so that for most user only the last message is shown), and only for the notified user avoid the collapsing |
plus, this requires the UI to use the new self_addr api |
I think there is a misconception of how collapsing works, it is useless in a turn-based game where different people will be sending the notification each time, plus even if it collapsed to older notifications from self it would just be super weird and useless info messages with the most recent notification being merged with an older info-message, anyways just to be sure it works as I said I tested it: |
notify the other player about
observers should not be notified.
this requires a core with deltachat/deltachat-core-rust#6230 checked out or merged
The text was updated successfully, but these errors were encountered: