Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to upcoming notify api (M2) #9

Closed
r10s opened this issue Nov 21, 2024 · 4 comments · Fixed by #10
Closed

adapt to upcoming notify api (M2) #9

r10s opened this issue Nov 21, 2024 · 4 comments · Fixed by #10
Assignees

Comments

@r10s
Copy link
Contributor

r10s commented Nov 21, 2024

notify the other player about

  • when an opponent joins
  • when a move is made

observers should not be notified.

this requires a core with deltachat/deltachat-core-rust#6230 checked out or merged

@r10s r10s moved this to Todo in Webxdc PUSH M2/M3 Nov 21, 2024
@adbenitez adbenitez self-assigned this Nov 21, 2024
@adbenitez
Copy link
Collaborator

adbenitez commented Nov 21, 2024

There is a problem I see here.... the notify API requires the notification message to be set in update.info which is not wanted/used in this game, since otherwise the chat will be spammed with "foo it is your turn" on every move, that is why this app was using the app summary for the notification of which user is the turn, so the notify API would need to use summary if info is not set or rather better have a dedicated notification text field, which would be the ideal because that way you can have custom message for user Foo that only Foo see in the UI

@r10s
Copy link
Contributor Author

r10s commented Nov 21, 2024

i am sceptical in having different messages etc. for different users, this might be somehow confusing as well - but we can always improve, not saying we cannot have sth like that at some point, but currently i do not think, it is needed and we should keep simple.

for the issue at hand, it is probably fine to just do the collapsing as usual (so that for most user only the last message is shown), and only for the notified user avoid the collapsing

@r10s
Copy link
Contributor Author

r10s commented Nov 21, 2024

this requires a core with deltachat/deltachat-core-rust#6230 checked out or merged

plus, this requires the UI to use the new self_addr api

@adbenitez
Copy link
Collaborator

for the issue at hand, it is probably fine to just do the collapsing as usual (so that for most user only the last message is shown), and only for the notified user avoid the collapsing

I think there is a misconception of how collapsing works, it is useless in a turn-based game where different people will be sending the notification each time, plus even if it collapsed to older notifications from self it would just be super weird and useless info messages with the most recent notification being merged with an older info-message, anyways just to be sure it works as I said I tested it:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants