Better handling of Escape key in modals for vim keybinds (I have a PR ready!)

[ian-h-chamberlain]

Hi, I was reminded by Kong's CLA bot that I had opened a PR to support rebinding "Escape" to something else for closing modal dialogs, which is useful for Vim keybind users since Escape normally just exits insert mode.

The issue from Insomnia was Kong/insomnia#4877 and the corresponding PR was Kong/insomnia#6573

Since they don't seem too interested in taking this small feature implementation, would the maintainers of Insomnium consider it? It should be fairly simple for me to rebase onto Insomnium and implement here, if you'd like it.

[archywillhe]

oh hey thanks! Sorry I'd been in radio-silence lately (due to some work stuff that past month)

Yup, https://github.com/ian-h-chamberlain/insomnia/tree/fix/customize-modal-keybind looks really good! Please feel free to open the PR;!

Also, I'm really curious about people coming from Insomnia -> let me know what will be the top things in a list that will make you want to switch to Insomnium; thanks (Or if Insomnium's v0.2.3-a is not-stable/not-good-enough for the use-case you want - will be good to know too)

[ian-h-chamberlain]

Awesome, thanks! I just opened #142

To be honest, I was already pretty happy with Insomnia at the time of fork, so it's probably only minor papercuts that I would generally look for at this point.

One bigger feature I would love is Kong/insomnia#777 — it looks like there might be an in-progress implementation upstream, but it seems like kind of a big feature so idk if it would make sense to take theirs or try to implement separately?

Thanks for maintaining this though, it has been nice to have an offline alternative that feels familiar!