Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing aiofiles with a different package #10

Closed
Archmonger opened this issue Jul 11, 2024 · 1 comment · Fixed by #27
Closed

Consider replacing aiofiles with a different package #10

Archmonger opened this issue Jul 11, 2024 · 1 comment · Fixed by #27

Comments

@Archmonger
Copy link
Owner

Description

We currently rely on aiofiles for async file reading, but it may not be the most performant option.

We will need to do some benchmarks and determine whether it should be replaced with aiofile,anyio, or asyncio.to_thread.

@Archmonger
Copy link
Owner Author

Archmonger commented Sep 4, 2024

I've created some benchmarks and it appears that asyncio.to_thread is the most performant under the majority of scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant