Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agents with low quality preferred names #4579

Closed
Jegelewicz opened this issue Apr 19, 2022 · 8 comments
Closed

Agents with low quality preferred names #4579

Jegelewicz opened this issue Apr 19, 2022 · 8 comments
Labels
Enhancement I think this would make Arctos even awesomer! Function-Agents Priority-High (Needed for work) High because this is causing a delay in important collection work..

Comments

@Jegelewicz
Copy link
Member

Jegelewicz commented Apr 19, 2022

Today I came across many agents with low quality preferred names. One example is C. E. Brown whose agent record record included his full first and middle names in the Agent names section. These low quality preferred names mean I waste time researching whether C. E. Brown might be the same person as Charles E. Brown from an incoming collection (it most certainly is), which I could have seen directly had the agent preferred name actually been Charles Edward Brown as was indicated via first_name, middle_name and last_name in the agent record.

I propose that we create a list of agents with preferred names that include initials, but also include complete first and/or middle name in those agent name fields and we update preferred name to be the most complete name we have for any given agent. This could save incoming collections considerable time when attempting to normalize agents.

C. E. Brown - changed to Charles Edward Brown
C. J. Maynard - changed to Charles Johnson Maynard

Also note that I was able to associate both agents with a Wikidata item once I had their full name...

@Jegelewicz Jegelewicz added Priority-High (Needed for work) High because this is causing a delay in important collection work.. Function-Agents Enhancement I think this would make Arctos even awesomer! labels Apr 19, 2022
@dustymc dustymc added this to the Needs Discussion milestone Apr 19, 2022
@dustymc
Copy link
Contributor

dustymc commented Apr 19, 2022

I want to agree, and I want to not.

If #4554 is in fact a step on a path to letting agents prefer whatever name they want, then 'CE' is (or will be) just fine and I'd rather not do this. (That would probably involve some generated and unique-keyed name type - displayed or not - in which we'd assemble 'Charles Edward Brown'.)

If we're not going in that direction, or maybe even if we're not going in that direction immediately, then this seems like something we should do.

Here's a starting point, Just In Case.

select agent.preferred_agent_name,
concat_ws(' ',fn.agent_name,mn.agent_name,ln.agent_name) as generated_name
from
agent
inner join agent_name fn on agent.agent_id=fn.agent_id and fn.agent_name_type='first name'
inner join agent_name mn on agent.agent_id=mn.agent_id and mn.agent_name_type='middle name'
inner join agent_name ln on agent.agent_id=ln.agent_id and ln.agent_name_type='last name'
where agent.preferred_agent_name != concat_ws(' ',fn.agent_name,mn.agent_name,ln.agent_name)

@Jegelewicz
Copy link
Member Author

Sigh.

Couldn't figure out why D. Dalager was on the list twice...

image

@Jegelewicz
Copy link
Member Author

And apparently I did that!

@Jegelewicz
Copy link
Member Author

There are 3,155 rows in the results. I see no reason to make a bunch of manual updates - I'd like to see us agree to just do it. Of course first we will need to clean up the agents that have more than one first_name, middle_name and/or last_name.

@ewommack
Copy link

ewommack commented Apr 19, 2022

Sigh.

Couldn't figure out why D. Dalager was on the list twice...

Ok walk me through what is wrong with the Delaine N. Dalager entry please. Is it coming up twice because of the aka?

@Jegelewicz
Copy link
Member Author

There is a first name = D. and a first name = Delaine

The script Dusty wrote made combinations of first, middle and last name so this person had two D. N. Delager and Delaine N. Dalager.

@ewommack
Copy link

There is a first name = D. and a first name = Delaine

Ah, thank you. So if we can clarify something in an agent it is better to replace the original poor quality first name (D.) with the full name (Delaine), and then write an aka with the initials spelling of the name.
Do I have that right?

@dustymc
Copy link
Contributor

dustymc commented Aug 24, 2022

Very very tentatively closing this. I think we have to get past the idea that "D." (or any other string) is somehow low quality (maybe that's just what they prefer, or what they were given by someone for some reason), and rely on context (dates, relationships, etc.) for "quality," even when picking.

If you don't know that stuff, then verbatim agents are functionally equivalent and what you should be using.

That said, I also don't want to ever encourage losing or withholding information. Delaine (probably) doesn't have to be in any particular place, but if they've used that at some point then it should be included somewhere.

#4554

@dustymc dustymc closed this as completed Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement I think this would make Arctos even awesomer! Function-Agents Priority-High (Needed for work) High because this is causing a delay in important collection work..
Projects
None yet
Development

No branches or pull requests

3 participants