Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report update questions - PDF: MVZ Ledger #8365

Open
dustymc opened this issue Dec 11, 2024 · 2 comments
Open

report update questions - PDF: MVZ Ledger #8365

dustymc opened this issue Dec 11, 2024 · 2 comments
Labels
collection-specific Pertains to a specific collection, and needs feedback or action from the collection staff function-Reports Priority-Normal (Not urgent) Normal because this needs to get done but not immediately.
Milestone

Comments

@dustymc
Copy link
Contributor

dustymc commented Dec 11, 2024

https://arctos.database.museum/Reports/reporter.cfm?action=edit&report_id=236

Possibly it's better to just tell me what you want instead of getting tangled up in the existing query, otherwise....

Possibly I can start by removing things that are in the query but not used, then ask whatever questions remain?? Other-otherwise....

I think hgeog is looking forcountry: state_prov: county - yes?

elev is either number-units, number-number-units, or null?

lat_long - not sure, bunch of mixed data, help?

 case when strpos(flat.parts,'wing') > 0 then 'wing' else NULL end wing,
        case when strpos(flat.parts,'skeleton') > 0 then 'skeleton' else '' end skeleton,
        case when strpos(flat.parts,'skull') > 0 then 'skull' else '' end skull,
        case when strpos(flat.parts,'body') > 0 then 'mount' else '' end mount,
        case when strpos(flat.parts,'whole organism (ethanol)') > 0 then 'fluid-prep' else '' end fluid,

I think that's not used, can I drop it? Otherwise please let me know the intent.

tissues - not used, is something needed??

accn_number - what is needed?

mamm_meas
bird_meas

hu?

prep_number etc - what is needed, these will all always return NULL

@dustymc dustymc added this to the Reporter milestone Dec 11, 2024
@mkoo
Copy link
Member

mkoo commented Dec 16, 2024

https://arctos.database.museum/Reports/reporter.cfm?action=edit&report_id=236

Possibly it's better to just tell me what you want instead of getting tangled up in the existing query, otherwise....

Possibly I can start by removing things that are in the query but not used, then ask whatever questions remain?? Other-otherwise....

There's a lot of unnecessary junk for sure...

I think hgeog is looking forcountry: state_prov: county - yes?

correct (if county is null then skip to avoid a hanging ":" since we concatenate the fields here so could be handled better

elev is either number-units, number-number-units, or null?

I like number-number-units and null if null

lat_long - not sure, bunch of mixed data, help?

ugh, code is making me cringe, but yes dec_lat, dec_long, datum as WGS84 if exists

 case when strpos(flat.parts,'wing') > 0 then 'wing' else NULL end wing,
        case when strpos(flat.parts,'skeleton') > 0 then 'skeleton' else '' end skeleton,
        case when strpos(flat.parts,'skull') > 0 then 'skull' else '' end skull,
        case when strpos(flat.parts,'body') > 0 then 'mount' else '' end mount,
        case when strpos(flat.parts,'whole organism (ethanol)') > 0 then 'fluid-prep' else '' end fluid,

I think that's not used, can I drop it? Otherwise please let me know the intent.

I dont what the intent is/was- skip please

tissues - not used, is something needed??

not needed

accn_number - what is needed?

I really dont know what the intent of the SQL is with accession number-- we just need the accession number (we havent had a strong tradition of preceding zeros so just the value!)

mamm_meas bird_meas

I dont think the previous accessions had the measurements (and it's not in the current form) so skip pls (we have measurements on the box labels and this is simply a borrowed SQL from those reports)

hu?

prep_number etc - what is needed, these will all always return NULL

basically we need the original number which is either the collector or preparator number; rarely there are both so usually just one or the other
Thanks!

@mkoo mkoo added Priority-Normal (Not urgent) Normal because this needs to get done but not immediately. function-Reports collection-specific Pertains to a specific collection, and needs feedback or action from the collection staff labels Dec 16, 2024
@dustymc
Copy link
Contributor Author

dustymc commented Dec 31, 2024

Pre-update:
PDF_MVZ_Ledger.csv.zip

I changed some stuff and cleaned up the SQL, let me know if that needs any further adjustments.

I'm not sure what's going on with the layout code, but I don't think it's going to result in valid HTML (and the server-side PDF-er will do near-random stuff if given invalid HTML). Let me know what the goal is if you need some help there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collection-specific Pertains to a specific collection, and needs feedback or action from the collection staff function-Reports Priority-Normal (Not urgent) Normal because this needs to get done but not immediately.
Projects
None yet
Development

No branches or pull requests

2 participants