Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Config's Standard Params and Advanced Params pages #3270

Closed
rmackay9 opened this issue Jan 5, 2024 · 5 comments · Fixed by #3274
Closed

Remove Config's Standard Params and Advanced Params pages #3270

rmackay9 opened this issue Jan 5, 2024 · 5 comments · Fixed by #3274

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Jan 5, 2024

image
@Hwurzburg and I think that it would be good to remove the Standrad Params and Advanced Params pages. I suspect very few people find the format easier to use than the Full Parameter List because:

  1. AP flight code doesn't include a good distinction of what is "Standard" vs "Advanced"
  2. the page lacks the search feature
  3. the Full Parameters page includes the bit setting feature and favourites
@IamPete1
Copy link
Member

IamPete1 commented Jan 6, 2024

I agree.

@timtuxworth
Copy link

timtuxworth commented Jan 6, 2024

I stopped using this screen because I never knew up front, if the parameter I wanted was "Advanced" or "Standard", and it just made it harder to find having to know this first.

@EosBandi
Copy link
Collaborator

EosBandi commented Jan 6, 2024

1.The whole idea of categorizing Advanced and Standard parameters is coming from the parameter metadata, defined in the source code by the @user field. keeping only the full param tree means that we no longer need that type of distinction ?
2. It does have a search feature (FIND) which search in the descriptions as well, not only in the param name like the full param list.
3. It also have a bit setting feature (using the same metadata as full param list)
4. Numerical Values are ARE forced to min/max boundaries, while full param list is not.
The only thing which is missing is the Favorites.

Basic and Advanced param screens created to use and 'enforce' boundaries, set in the parameter metadata, do we really want to get rid of it ?

@Hwurzburg
Copy link
Contributor

Hwurzburg commented Jan 6, 2024

yes...Full Param List does that value check also ....Std vs Advanced tagging has been inconsistent and really is meaningless since the what is advanced to one user would be std to another... back when there were much fewer params, std vs advanced MAY have steered noobs away from messing with params they did not understand or ,more likely, not covered in the wiki...not effective now

@EosBandi
Copy link
Collaborator

EosBandi commented Jan 6, 2024

OK. I think the most non disruptive way is to redo the layouts

  • Add Full Params list to Basic layout and remove standard/advanced
  • Remove stadard/advanced from Advanced layout
  • Keep the current basic and advanced layouts as basic-legacy and advanced-legacy if somebody still wants to use standard/advanced params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants