Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup: Reviewing Redundancies in AP_OSD_MSP #29502

Open
lida2003 opened this issue Mar 11, 2025 · 0 comments
Open

Code Cleanup: Reviewing Redundancies in AP_OSD_MSP #29502

lida2003 opened this issue Mar 11, 2025 · 0 comments

Comments

@lida2003
Copy link
Contributor

lida2003 commented Mar 11, 2025

It appears that the AP_OSD_MSP module does not implement any specific functionality and may be redundant. If this section of the code is indeed unnecessary, it could be considered for cleanup to streamline the codebase and reduce maintenance overhead. A thorough review is recommended to confirm whether any dependencies exist before proceeding with its removal.

https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_OSD/AP_OSD_MSP.h

I think the feature has been implemented by code below:

if (msp && msp->is_option_enabled(AP_MSP::Option::DISPLAYPORT_BTFL_SYMBOLS)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant