Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RabbitMQ Client 7.0 #156

Closed
ArieGato opened this issue Feb 10, 2024 · 9 comments · Fixed by #218
Closed

Implement RabbitMQ Client 7.0 #156

ArieGato opened this issue Feb 10, 2024 · 9 comments · Fixed by #218

Comments

@ArieGato
Copy link
Owner

Investigate consequences of all breaking changes.

Can we support both versions? Maybe create two nuget packages.

@sungam3r
Copy link
Collaborator

Maybe create two nuget packages.

Not two packages with different names, but two different versions - v7 and v8. You already bumped serilog to v3 that is a breaking change. I suggest to accumulate all other changes in v7 except bumping rabbitmq to v7, release v7 of sink and then publish v8 of sink with rabbitmq v7.

@ArieGato
Copy link
Owner Author

This is definitly not going to be part of v7. It's more of a discussion about how we want to handle this.

At the moment RabbitMQClient 7 has an alpha status.

The question is whether we want to stop supporting RabbitMQClient 6.x in v8.

@sungam3r
Copy link
Collaborator

It depends of when rabbitmq goes from alpha to stable. It can be in alpha for years. V8 of this sink may have some unrelated to rabbitmq 7 breaking changes. Who knows.

@sungam3r
Copy link
Collaborator

@lukebakken
Copy link

Hello! I am the primary maintainer of the RabbitMQ .NET client. If you would like to speed along the release of version 7, testing alpha releases is a great way to help out -

https://www.nuget.org/packages/RabbitMQ.Client/7.0.0-alpha.6

I really would like to get everything wrapped up this month 🤞

@ArieGato
Copy link
Owner Author

ArieGato commented May 19, 2024

@lukebakken Is there a migration guid?

I can't seem to find IModel.CreateBasicProperties.

@lukebakken
Copy link

@ArieGato no, there is no guide at this point in time. The API remains very similar to before, and the test suites are very thorough, so you should be able to figure out the necessary changes. If you need assistance, the best place to ask is here:

https://github.com/rabbitmq/rabbitmq-dotnet-client/discussions

One "big" change is the rename of IModel to IChannel.

@ArieGato
Copy link
Owner Author

ArieGato commented Oct 6, 2024

Hi @lukebakken I implemented the RabbitMQ client 7. Do you have an estimate when the final release will be. I want to start scheduling a breaking version myself and would like to include the new client.

@lukebakken
Copy link

Hopefully this month (October 2024). No promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants