Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: should output from tools have a conventional key as well? #37

Open
tslmy opened this issue Dec 31, 2023 · 1 comment
Open

Tools: should output from tools have a conventional key as well? #37

tslmy opened this issue Dec 31, 2023 · 1 comment

Comments

@tslmy
Copy link

tslmy commented Dec 31, 2023

There is llm.output_messages for LLM calls. There is embedding.vector for embedding model calls. There is retrieval.documents for retrieval results. But there is no tool_call.output for tool calls:

| `tool.description` | String | `"An API to get weather data."` | Description of the tool's purpose and functionality |
| `tool.parameters` | JSON string | `"{ 'a': 'int' }"` | The parameters definition for invoking the tool |

Should we add it?

I believe this is the cause of run-llama/llama_index#9770 .

@mikeldking
Copy link
Contributor

hi @tslmy thanks for filing an issue. Good call-out. the output of tools very often shows up in the subsequent LLM call but you are right - it's probably a good idea to capture this as part of the span. We will work with the LlamaIndex team to get visibility into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants