Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Support Hiding Invocation Parameters in Spans #1170

Closed
rajaswa opened this issue Dec 13, 2024 · 4 comments · Fixed by #1171
Closed

[feature request] Support Hiding Invocation Parameters in Spans #1170

rajaswa opened this issue Dec 13, 2024 · 4 comments · Fixed by #1171
Assignees
Labels
enhancement New feature or request

Comments

@rajaswa
Copy link

rajaswa commented Dec 13, 2024

Is your feature request related to a problem? Please describe.
Currently there is no support to hide invocation parameters in Spans - which might contain sensitive information like api_keys.

Describe the solution you'd like
The TraceConfig class can start supporting a hide_invocation_params property, which will REDACT invocation parameters.

Describe alternatives you've considered
N/A

Additional context
N/A

@rajaswa rajaswa added enhancement New feature or request triage Issues that require triage labels Dec 13, 2024
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Dec 13, 2024
@RogerHYang RogerHYang self-assigned this Dec 13, 2024
@RogerHYang RogerHYang removed the triage Issues that require triage label Dec 13, 2024
@axiomofjoy
Copy link
Contributor

@rajaswa Are you seeing anywhere that we store API keys in spans? This is a mistake if so.

@rajaswa
Copy link
Author

rajaswa commented Dec 13, 2024

@rajaswa Are you seeing anywhere that we store API keys in spans? This is a mistake if so.

@axiomofjoy Yes, I am seeing api_key being logged in the Spans UI under Invocation Params tab with the below schema (this is for DSPy with LiteLLM-based Azure OpenAI LLM Call)

{
  "num_retries": 3,
  "cache": {
    "no-cache": true,
    "no-store": true
  },
  "temperature": 0.3,
  "max_tokens": 4096,
  "api_base": "<my-azure-openai-url",
  "api_version": "2024-06-01",
  "api_key": "my-azure-openai-key"
}

@RogerHYang
Copy link
Contributor

@rajaswa We've added this ability in v0.1.20 via the hide_llm_invocation_parameters option. Please let us know if you have further questions. Thank you!

@rajaswa
Copy link
Author

rajaswa commented Dec 14, 2024

Thanks @RogerHYang! I have updated the Phoenix docs with the same, hope it helps! - Arize-ai/phoenix#5739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants