feat(crewAI): Added trace config, context attributes, suppress tracing for CrewAI #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
fjcasti1
reviewed
Aug 13, 2024
| @@ -206,6 +212,7 @@ def __call__( | |||
| raise | |||
| span.set_status(trace_api.StatusCode.OK) | |||
| span.set_attribute(OUTPUT_VALUE, response) | |||
| span.set_attributes(dict(get_attributes_from_context())) | |||
There was a problem hiding this comment.
We want to set these attributes first, check other implementations if you need more details but you can simply add it to the start_as_current_span call
fjcasti1
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #731
Resolves: #748
Resolves: #719
Notes: