feat(crewai): Add SpanKind and Token Count attributes #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
dosubot
bot
added
size:L
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
harrisonchu
changed the title
harrisonchu
changed the title
fjcasti1
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Use footers to trigger release please release notes notes instead of making the title a "multi-title". See https://github.com/googleapis/release-please?tab=readme-ov-file#what-if-my-pr-contains-multiple-fixes-or-features
PS: would love a training session on vrcpy ;)
python/examples/llama-index/backend/app/engine/loaders/__init__.py
Outdated
Show resolved
Hide resolved
...n/openinference-instrumentation-crewai/src/openinference/instrumentation/crewai/_wrappers.py
Outdated
Show resolved
Hide resolved
...n/openinference-instrumentation-crewai/src/openinference/instrumentation/crewai/_wrappers.py
Outdated
Show resolved
Hide resolved
...n/openinference-instrumentation-crewai/src/openinference/instrumentation/crewai/_wrappers.py
Outdated
Show resolved
Hide resolved
...rence-instrumentation-crewai/tests/openinference/instrumentation/crewai/test_instrumentor.py
Show resolved
Hide resolved
python/instrumentation/openinference-instrumentation-litellm/guides/client_demo.ipynb
Outdated
Show resolved
Hide resolved
...mentation/openinference-instrumentation-promptflow/examples/chat_flow_example_to_arize.ipynb
Outdated
Show resolved
Hide resolved
...ntation/openinference-instrumentation-promptflow/examples/chat_flow_example_to_phoenix.ipynb
Outdated
Show resolved
Hide resolved
fjcasti1
reviewed
Aug 20, 2024
Comment on lines
218
to
223
| if "prompt_tokens" in usage_metrics: | ||
| span.set_attribute(LLM_TOKEN_COUNT_PROMPT, int(usage_metrics["prompt_tokens"])) | ||
| if "completion_tokens" in usage_metrics: | ||
| span.set_attribute(LLM_TOKEN_COUNT_COMPLETION, int(usage_metrics["completion_tokens"])) | ||
| if "total_tokens" in usage_metrics: | ||
| span.set_attribute(LLM_TOKEN_COUNT_TOTAL, int(usage_metrics["total_tokens"])) |
There was a problem hiding this comment.
Suggested change
| if "prompt_tokens" in usage_metrics: | |
| span.set_attribute(LLM_TOKEN_COUNT_PROMPT, int(usage_metrics["prompt_tokens"])) | |
| if "completion_tokens" in usage_metrics: | |
| span.set_attribute(LLM_TOKEN_COUNT_COMPLETION, int(usage_metrics["completion_tokens"])) | |
| if "total_tokens" in usage_metrics: | |
| span.set_attribute(LLM_TOKEN_COUNT_TOTAL, int(usage_metrics["total_tokens"])) | |
| if prompt_tokens := usage_metrics.get("prompt_tokens"): | |
| span.set_attribute(LLM_TOKEN_COUNT_PROMPT, int(prompt_tokens)) | |
| if completion_tokens := usage_metrics.get("completion_tokens"): | |
| span.set_attribute(LLM_TOKEN_COUNT_COMPLETION, int(completion_tokens)) | |
| if total_tokens := usage_metrics.get("total_tokens"): | |
| span.set_attribute(LLM_TOKEN_COUNT_TOTAL, int(total_tokens)) |
Comment on lines
+226
to
+228
| span.set_attribute(LLM_TOKEN_COUNT_PROMPT, usage_metrics.prompt_tokens) | ||
| span.set_attribute(LLM_TOKEN_COUNT_COMPLETION, usage_metrics.completion_tokens) | ||
| span.set_attribute(LLM_TOKEN_COUNT_TOTAL, usage_metrics.total_tokens) |
There was a problem hiding this comment.
Are we absolutely certain these are set?
There was a problem hiding this comment.
yea in later versions it's set right before the end of the kickoff main function
There was a problem hiding this comment.
Should this litellm notebook be in this PR?
fjcasti1
reviewed
Aug 20, 2024
harrisonchu
changed the title
fjcasti1
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves Arize-ai/phoenix#4200
fix(crewai): add basic unit tests