Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anthropic): streaming support #990

Merged
merged 42 commits into from
Oct 2, 2024
Merged

feat(anthropic): streaming support #990

merged 42 commits into from
Oct 2, 2024

Conversation

harrisonchu
Copy link
Contributor

@harrisonchu harrisonchu commented Aug 30, 2024 •
edited
Loading

  • add streaming support for completions
  • add streaming support for async completions
  • add streaming support for messages
  • add streaming support for async messages
  • add streaming support for tool calling response
  • resolve issues around assumptions about first content block in a message being a text output
  • resolve all other TODOs

@harrisonchu harrisonchu requested a review from a team as a code owner August 30, 2024 17:05
@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
phoenix-vercel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 4:24pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 30, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 1, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 1, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 1, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 2, 2024
@harrisonchu harrisonchu changed the title Anthropic streaming (wip) feat(anthropic): streaming support Sep 2, 2024
@harrisonchu harrisonchu mentioned this pull request Sep 3, 2024
Open
@axiomofjoy
Copy link
Contributor

@harrisonchu Is this one ready for review, or do you want to wait till you get back from PTO?

anticorrelator
anticorrelator approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@anticorrelator anticorrelator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 1, 2024
@harrisonchu harrisonchu merged commit f3b7b96 into main Oct 2, 2024
5 checks passed
@harrisonchu harrisonchu deleted the anthropic-streaming branch October 2, 2024 23:53
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Merged
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anticorrelator anticorrelator anticorrelator approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrisonchu @axiomofjoy @anticorrelator