Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] mp4 video rendering of video URLs #1048

Closed
mikeldking opened this issue Aug 8, 2023 · 6 comments · Fixed by #1630
Closed

[ENHANCEMENT] mp4 video rendering of video URLs #1048

mikeldking opened this issue Aug 8, 2023 · 6 comments · Fixed by #1630
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mikeldking
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Embeddings can represent video as well as the captions associated with it. Phoenix should render these video URLs.

Note

The video might require signing for AWS or Google Cloud.

@mikeldking mikeldking added enhancement New feature or request help wanted Extra attention is needed labels Aug 8, 2023
@tomukmatthews
Copy link

tomukmatthews commented Oct 6, 2023

Hello @mikeldking ! May i humbly request that we bump this feature please? Our team is very keen to make use of this!! If you / your team don't have time to work on this would you be open to open source contributions?

@mikeldking
Copy link
Contributor Author

Hello @mikeldking ! May i humbly request that we bump this feature please? Our team is very keen to make use of this!! If you / your team don't have time to work on this would you be open to open source contributions?

hey @tomukmatthews good to hear from you! Yeah sorry this has been sitting there - Can I ask some clarifying questions:

  • What are the file extensions you are using for the video - do they always end with a specific extension? Because if it's not natively embeddable via HTML video easily this might be tough
  • When you launch the application, does the browser you view the notebook in have direct access to the videos? E.g. there is no signing that has to happen, the URLs can be directly accessed?

If possible could you send an example URL of a video? No need for it to be a real URL for privacy reasons ofc but it will help me understand whether or not we can tackle this via extensions. AKA I think this will be significantly harder if we need to rely on MIME types etc.

On the contributions side Ofc! Would love to have you contribute :)

@tomukmatthews
Copy link

No problem at all, i appreciate you taking feature requests in the first place!

  • Our video extensions are mostly mp4, sometimes mov.
  • Yes the browser would have access, our data lives in private S3 buckets, however i would generate presigned url's before firing up phoenix so that the URL's could be directly accessed 👍 an example presigned url looks like this: https://s3.<region>.amazonaws.com/<bucket>/<folder>/<video_id>.mp4?AWSAccessKeyId=<AWS_access_key>&Signature=<signature>&x-amz-security-token=<token>&Expires=<expiration_time>

@mikeldking
Copy link
Contributor Author

Thanks for the details @tomukmatthews ! I'll give it a stab.

@mikeldking
Copy link
Contributor Author

@tomukmatthews I added support for rendering <video> in 0.0.49 - this should get you basically what you need - althought you might have issues with the URL being hit as you select and needing thumbnails. LMK if you have issues (notably with things like .mov).

We can attempt some optemizations if need be.

@tomukmatthews
Copy link

Thanks so much @mikeldking! I'm planning to test this out as soon as i can find some time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants