Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pin tutorials to openai<1 #1718

Merged
merged 9 commits into from
Nov 7, 2023
Merged

docs: pin tutorials to openai<1 #1718

merged 9 commits into from
Nov 7, 2023

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Nov 7, 2023

This is a temporary fix until the migration to openAI 1 can be achieved. It pins both openAI as well as langchain and llamaIndex to pre Nov 6 until we have openAI 1.0 fully working.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mikeldking mikeldking marked this pull request as ready for review November 7, 2023 20:05
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw that you're adding back in the -qq flag. I thought we found that that flag was suppressing a useful reload button in Colab?

@mikeldking
Copy link
Contributor Author

Saw that you're adding back in the -qq flag. I thought we found that that flag was suppressing a useful reload button in Colab?

@axiomofjoy yeah it is useful but I added it to the eval notebooks since those we don't sanitize the output. I don't really want it capturing my environment info as I run. The case where it was useful was when llama_index introduced a breaking change. I think it's less likely for evals and I don't want to store kb of install lines since it clutters the readability as well

@mikeldking mikeldking merged commit 831c041 into main Nov 7, 2023
6 checks passed
@mikeldking mikeldking deleted the pin-notebooks branch November 7, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants