feat(traces): configurable endpoint for the exporter #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeldking
changed the title
axiomofjoy
approved these changes
Nov 21, 2023
src/phoenix/config.py
Outdated
|
|
||
|
|
||
| def get_env_trace_endpoint() -> Optional[str]: | ||
| return os.getenv(ENV_TRACE_ENDPOINT) or None |
There was a problem hiding this comment.
Suggested change
| return os.getenv(ENV_TRACE_ENDPOINT) or None | |
| return os.getenv(ENV_TRACE_ENDPOINT) |
os.getenv returns None if the environment variable can't be found.
RogerHYang
reviewed
Nov 21, 2023
src/phoenix/config.py
Outdated
| @@ -7,6 +7,7 @@ | |||
| ENV_PHOENIX_PORT = "PHOENIX_PORT" | |||
| ENV_PHOENIX_HOST = "PHOENIX_HOST" | |||
| ENV_NOTEBOOK_ENV = "PHOENIX_NOTEBOOK_ENV" | |||
| ENV_TRACE_ENDPOINT = "PHOENIX_TRACE_ENDPOINT" | |||
There was a problem hiding this comment.
keep it generic?
Suggested change
| ENV_TRACE_ENDPOINT = "PHOENIX_TRACE_ENDPOINT" | |
| ENV_PHOENIX_RECEIVER_ENDPOINT = "PHOENIX_RECEIVER_ENDPOINT" |
There was a problem hiding this comment.
Oh yeah evals. Was copying OTEL naming but maybe I'll just call it collector
RogerHYang
approved these changes
Nov 21, 2023
mikeldking
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1793
This PR introduces an
endpointconfig for the exporter so that we don't assume that the phoenix server is running locally. This is needed for various use-cases:Phoenix can now be running on an EC2 instance or other
Phoenix might have to be running in Sagemaker studio in a separate process (Networking failing right now but in theory this might be the configuration)