Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (potentially fragmenting the parent-child graph of the spans) #1796

Closed
RogerHYang opened this issue Nov 21, 2023 · 0 comments
Labels

Comments

@RogerHYang
Copy link
Contributor

RogerHYang commented Nov 21, 2023

In llama-index 0.9.5, retriever starts a new trace and new callback manager (of BaseRetriever), instead of just a new span under the same trace and same callback manager of its parent span.

In general, there are too many ways a different callback manager can specified for each portion of a trace. This can lead to the fragmentation of the trace map (i.e. the parent-child graph of the spans), because each callback manager keeps and updates a separate trace map. When phoenix receive the final trace map, it only come from one callback manager, and the trace map may not be a complete version containing all the spans.

Alternatively, we can construct our own trace map using the parent_id argument in on_event_start, but that has the downside of a potential memory leak: we may not know when the trace map can be destroyed.

@RogerHYang RogerHYang added bug Something isn't working triage issues that need triage labels Nov 21, 2023
@RogerHYang RogerHYang self-assigned this Nov 21, 2023
@RogerHYang RogerHYang removed the triage issues that need triage label Nov 21, 2023
@RogerHYang RogerHYang changed the title [BUG] retriever span in llama-index 0.9.5 is now put under a new trace that doesn't inherit the Phoenix handler (so CBEventType.RETRIEVE doesn't get to Phoenix) [BUG] retriever span in llama-index 0.9.5 is now put under a new trace (instead of under the same trace as its parent span) Nov 21, 2023
@RogerHYang RogerHYang changed the title [BUG] retriever span in llama-index 0.9.5 is now put under a new trace (instead of under the same trace as its parent span) [BUG] retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (instead of under the same trace and same callback manager as its parent span) Nov 21, 2023
@RogerHYang RogerHYang changed the title [BUG] retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (instead of under the same trace and same callback manager as its parent span) retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (instead of under the same trace and same callback manager as its parent span) Nov 21, 2023
@RogerHYang RogerHYang removed the bug Something isn't working label Nov 21, 2023
@RogerHYang RogerHYang removed their assignment Nov 21, 2023
@RogerHYang RogerHYang changed the title retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (instead of under the same trace and same callback manager as its parent span) retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (potentially fragmenting the trace map) Nov 21, 2023
@RogerHYang RogerHYang changed the title retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (potentially fragmenting the trace map) retriever span in llama-index 0.9.5 is now put under a new trace and new callback manager (potentially fragmenting the parent-child graph of the spans) Nov 21, 2023
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jun 8, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant