-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance llama-index callback support for exception events #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
RogerHYang
approved these changes
Nov 28, 2023
should we bump the |
Good catch, addressed in e8c8a71. |
mikeldking
pushed a commit
that referenced
this pull request
Nov 28, 2023
mikeldking
pushed a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LlamaIndex recently changed the way their callback system handles exception information. Previously, exceptions always resulted in independent exception callback events. Now, whenever possible, exception information is passed via the
on_event_end
callback hook for the callback event that caused the exception. When that is not possible (e.g., when the exception arises outside of any event), the callback system produces an independent exception event containing the exception information. This latter scenario should be rare and indicates that there is a bug in LlamaIndex itself.This PR adjusts our callback handler to accommodate these changes. In particular, it searches each callback event payload for an
EventPayload.EXCEPTION
key, and if present, grabs the exception information from that key. In the infrequent but possible event that the LlamaIndex callback system registers an independent exception callback event, we create a span of span kind "chain" and attach the exception information to this span.Note that LlamaIndex is currently incorrectly passing the exception information for failed LLM calls (e.g., due to rate limit errors) to the parent synthesis span in the case of query engines. I've adjusted the unit tests accordingly for now. I've noted to the LlamaIndex team here.
I will handle percolating exceptions up the span tree in a subsequent PR.
Relevant issues: