fix(traces): make column selector sync'd between tabs #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerHYang
approved these changes
Nov 28, 2023
mikeldking
added a commit
that referenced
this pull request
Nov 28, 2023
* fix(traces): make column selector sync'd between tabs * lint * reverse the aliasing so columns show/hide together
mikeldking
added a commit
that referenced
this pull request
Dec 1, 2023
* fix(traces): make column selector sync'd between tabs * lint * reverse the aliasing so columns show/hide together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1807
Makes the column selector work on the spans tab and keeps the visibility state in sync across the two tabs by creating a central zustand store (which will be extended).